Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Create .eslintrc.js and update eslint related deps #2655

Merged
merged 2 commits into from
Oct 22, 2017

Conversation

adityavohra7
Copy link
Contributor

Updated eslint and some related deps. They still satisfy (I think?) the peer deps declared by eslint-config-react-app. I also changed .eslintrc to .eslintrc.js as it's treated with highest priority (and we could do any kind of logic in a JS file). Also, this version of eslint allows us to specify overrides, so we don't need the .eslintrc in the test/ folder anymore.

lint and test still seem to pass:

➜  redux git:(update_eslint_things) npm run lint

> [email protected] lint /Users/adityavohra7/Documents/Github/redux
> eslint src test build

➜  redux git:(update_eslint_things) echo $?
0
➜  redux git:(update_eslint_things) npm run test

> [email protected] test /Users/adityavohra7/Documents/Github/redux
> cross-env BABEL_ENV=commonjs jest

 PASS  test/typescript.spec.js
 PASS  test/createStore.spec.js
 PASS  test/combineReducers.spec.js
 PASS  test/applyMiddleware.spec.js
 PASS  test/bindActionCreators.spec.js
 PASS  test/utils/warning.spec.js
 PASS  test/compose.spec.js

Test Suites: 7 passed, 7 total
Tests:       69 passed, 69 total
Snapshots:   0 total
Time:        3.196s
Ran all test suites.
➜  redux git:(update_eslint_things) echo $?
0

Let me know what you think!

@adityavohra7
Copy link
Contributor Author

Friendly bump! Let me know if there are any questions I can answer, or if I'm doing something horribly horribly wrong.

@timdorr
Copy link
Member

timdorr commented Oct 22, 2017

Thanks, this is neat!

@timdorr timdorr merged commit 1b19650 into reduxjs:master Oct 22, 2017
@adityavohra7 adityavohra7 deleted the update_eslint_things branch October 23, 2017 04:40
@adityavohra7
Copy link
Contributor Author

@timdorr, awesome! Thanks for merging! Would you be open to a PR adding prettier?

seantcoyote pushed a commit to seantcoyote/redux that referenced this pull request Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants