fixes to bindActionCreators overloads #3552
Conversation
| @@ -35,6 +35,25 @@ function bindActionCreator<A extends AnyAction = AnyAction>( | |||
| * function as `actionCreators`, the return value will also be a single | |||
| * function. | |||
| */ | |||
| export default function bindActionCreators<A, C extends ActionCreator<A>>( | |||
There was a problem hiding this comment.
Please don't use single character generic names.
I haven't gone through the existing types to fix this, but I want to start enforcing it now. Preferably via a linting rule.
There was a problem hiding this comment.
I thought this was the de facto standard for naming generics
There was a problem hiding this comment.
I agree with @timdorr, descriptive names are better if the generic is longer than 1 line.
As for this PR, it is a copy/paste from the existing types in index.d.ts (https://github.com/reduxjs/redux/blob/master/index.d.ts#L559)
How would you feel about doing a follow-up PR that renames everything once we've got the whole thing converted to TS? Suggested steps:
- make it work as-is, with as few changes as possible
- merge in fix replaceReducer with a store enhancer #3524 (this is good to go, and will be much harder to rebase after the template variable renames)
- rename all the things
There was a problem hiding this comment.
Yep! I definitely want us to do incremental, history-traceable, step-by-step changes throughout this whole task. And yes, I'm on board with making types more clearly named.
cellog
force-pushed
the
cellog-3500-bindActionCreators-fixes
branch
from
fcd6394 to
cc4f58c
Compare
this adds overloads to
bindActionCreatorsand fixes the import