explain a little more what a single reducer in combination is #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,8 @@ reducing function you can pass to [`createStore`](createStore.md). | |||
|
|
|||
| The resulting reducer calls every child reducer, and gather their results into a single state object. The shape of the state object matches the keys of the passed `reducers`. | |||
|
|
|||
| Reducer function names are important. Don't be confused by the fact that reducer parameter is named `state`. *Single reducer in the combination does not update compete state of the store.* Its name is the key of the value in the store object it gets and updates. For example, reducer named `todos` receives and changes only `state.todos`. | |||
There was a problem hiding this comment.
I'd say it's not exactly function names but keys in object you pass to combineReducers. They match function names when you use export syntax.
|
I was surprised too. It is good, but it should be in the docs |
|
Thanks. This is on my list to revisit. I added quite a bit about it into reducers doc.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if its my bad luck, but coming from facebook flux and seeing that every reducer in examples have parameter
state, I assumed that every reducer manipulates complete state of the application. It took me quite a few hours before I found out that when you usecombineReducersthings are different. Maybe docs could be a bit more explicit about that.