-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix url rewrite with clean urls #1057
Conversation
3f78051
to
1bd6711
Compare
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 68.86% 68.91% +0.05%
==========================================
Files 222 222
Lines 21385 21385
==========================================
+ Hits 14726 14738 +12
+ Misses 5331 5315 -16
- Partials 1328 1332 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
7972dea
to
1bd6711
Compare
Opened a follow up for content not being displayed correctly when navigating directly to |
Weirdly enough, sub-pages of https://deploy-preview-1057--regen-ledger-docs.netlify.app/modules/ecocredit/ This seems like a fine solution for now. I don't think the formatting thing is worth blocking on. If I had any hesitation, it would be in bringing in a package that hasn't been updated in 2 years... but i think this is probably fine. Its a small workaround, and we can update again if the package gets out of date with vuepress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Navigating to https://docs.regen.network/modules/ directly rewrites the url to https://docs.regen.network/modules.html, which does not read the sidebar and breaks the links. This pull request adds a plugin to prevent this.
This pull request fixes the links but the content is not displayed correctly when navigating directly to
modules
orcommands
. I was unable to resolve the issue so opened a followup that would be nice to fix at a later point in time #1058.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change