Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codecov configuration #1230

Merged
merged 8 commits into from
Jul 5, 2022
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jul 2, 2022

Description

Closes: #1151


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

.codecov.yml Outdated
Comment on lines 5 to 6
# Codecov Report:
# https://app.codecov.io/gh/regen-network/regen-ledger
Copy link
Member Author

@ryanchristo ryanchristo Jul 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend taking a look at this to see where we might want to improve tests. Also it looks like some tests are not running as expected, in particular I noticed message validation for MsgBridge and MsgBridgeReceive are showing up with poor coverage maybe caused by misuse of t.Parallel(). 👀

https://app.codecov.io/gh/regen-network/regen-ledger/compare/1230/tree/x/ecocredit/core/msg_bridge.go
https://app.codecov.io/gh/regen-network/regen-ledger/compare/1230/tree/x/ecocredit/core/msg_bridge_receive.go

@ryanchristo ryanchristo marked this pull request as ready for review July 2, 2022 06:05
@ryanchristo ryanchristo force-pushed the ryan/1151-update-codecov branch from b46222f to ae23e6e Compare July 2, 2022 18:36
@ryanchristo ryanchristo merged commit e887154 into master Jul 5, 2022
@ryanchristo ryanchristo deleted the ryan/1151-update-codecov branch July 5, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code coverage to exclude simulation operations
3 participants