Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/ecocredit): basket curator migration #1281

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jul 20, 2022

Description

Closes: #1280


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 marked this pull request as ready for review July 20, 2022 05:37
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #1281 (053bbc8) into master (a57af9c) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1281      +/-   ##
==========================================
- Coverage   77.56%   77.50%   -0.06%     
==========================================
  Files         213      213              
  Lines       16156    16158       +2     
==========================================
- Hits        12531    12524       -7     
- Misses       2627     2639      +12     
+ Partials      998      995       -3     
Flag Coverage Δ
experimental-codecov 77.61% <33.33%> (-0.06%) ⬇️
stable-codecov 77.28% <33.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/ecocredit/migrations/v3/patch.go 72.88% <33.33%> (-1.26%) ⬇️
types/ormstore/store.go 33.55% <0.00%> (-2.29%) ⬇️

@ryanchristo ryanchristo added the backport/v4.0.x backport to release/v4.0.x branch label Jul 20, 2022
@ryanchristo ryanchristo changed the title fix(ecocredit): basket curator migration fix(x/ecocredit): basket curator migration Jul 20, 2022
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Can you add a changelog entry to unreleased v4.0?

### Fixed

- [#1281](https://github.com/regen-network/regen-ledger/pull/1281) Fix curator address in state migrations

@ryanchristo ryanchristo merged commit 4e24986 into master Jul 20, 2022
@ryanchristo ryanchristo deleted the aleem/1280-basket-curator branch July 20, 2022 16:32
mergify bot pushed a commit that referenced this pull request Jul 20, 2022
* fix: basket curator migration

* chore: add changelog

(cherry picked from commit 4e24986)

# Conflicts:
#	CHANGELOG.md
ryanchristo added a commit that referenced this pull request Jul 20, 2022
* fix(x/ecocredit): basket curator migration (#1281)

* fix: basket curator migration

* chore: add changelog

(cherry picked from commit 4e24986)

# Conflicts:
#	CHANGELOG.md

* resolve conflicts

* resolve conflicts

Co-authored-by: MD Aleem <[email protected]>
Co-authored-by: ryanchristo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v4.0.x backport to release/v4.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basket curator incorrect address after redwood state migration
3 participants