test(x/ecocredit): add bridge integration tests #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1297 +/- ##
==========================================
+ Coverage 77.48% 77.50% +0.01%
==========================================
Files 220 221 +1
Lines 16130 16160 +30
==========================================
+ Hits 12499 12524 +25
- Misses 2612 2621 +9
+ Partials 1019 1015 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ryanchristo
commented
Jul 24, 2022
Comment on lines
-465
to
-466
| // recipient is the address of the contract handling the bridged credits. | ||
| string contract = 4; |
There was a problem hiding this comment.
The logic for this was already removed as we are now using batch contract mapping to check if credits can be bridged back to the source chain. If a batch contract mapping exists, the stored contract is used. It looks like I forgot to remove this field or I accidentally added it back in with a merge.
aleem1314
approved these changes
Jul 25, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
* test(x/ecocredit): add bridge integration tests * add expect project properties * add bridge receive event check * add steps and testing reverse direction * use different address for recipient * use iteration to generate keys * expect error in code block (cherry picked from commit 1785310)
ryanchristo
added a commit
that referenced
this pull request
Jul 25, 2022
* test(x/ecocredit): add bridge integration tests (#1297) * test(x/ecocredit): add bridge integration tests * add expect project properties * add bridge receive event check * add steps and testing reverse direction * use different address for recipient * use iteration to generate keys * expect error in code block (cherry picked from commit 1785310) * make tidy Co-authored-by: Ryan Christoffersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds integration tests for bridging credits from polygon to regen and then back to polygon. This pull request also removes the unused
contractfield fromMsgBridgeas we are now using the stored contract inBatchContractwhen credits are bridged usingMsgBridgeReceive(this field should have been removed when adding batch contract mapping).Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change