refactor(x/ecocredit): update basket validation functions #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgwz
approved these changes
Aug 23, 2022
| @@ -132,7 +132,7 @@ Feature: MsgCreate | |||
| } | |||
| """ | |||
| When the message is validated | |||
| Then expect the error "name must start with an alphabetic character, and be between 3 and 8 alphanumeric characters long: invalid request" | |||
| Then expect the error "name: expected format [a-zA-Z][a-zA-Z0-9]{2,7}: parse error: invalid request" | |||
There was a problem hiding this comment.
perhaps we should opt for a more human readable error for users who might not understand regex?
There was a problem hiding this comment.
Yea, regex is probably not the most user friendly. 👍
aleem1314
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #1245
This pull request updates utility functions in the ecocredit module to use a consistent format and check empty string within the validation method rather than individually within each message validation.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change