Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): query all balances cmd #1443

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Aug 30, 2022

Description

  • adds a cobra command to utilize the all-balances query

Closes: #1435


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1443 (5b63179) into main (c3ce116) will increase coverage by 0.00%.
The diff coverage is 82.50%.

@@           Coverage Diff           @@
##             main    #1443   +/-   ##
=======================================
  Coverage   78.41%   78.42%           
=======================================
  Files         240      240           
  Lines       18359    18399   +40     
=======================================
+ Hits        14397    14430   +33     
- Misses       3126     3131    +5     
- Partials      836      838    +2     
Impacted Files Coverage Δ
x/ecocredit/client/query.go 0.00% <0.00%> (ø)
x/ecocredit/base/client/query.go 68.95% <76.00%> (+0.41%) ⬆️
x/ecocredit/client/testsuite/query.go 99.52% <100.00%> (+<0.01%) ⬆️

@technicallyty technicallyty marked this pull request as ready for review August 30, 2022 23:29
@technicallyty technicallyty requested a review from a team August 30, 2022 23:29
@ryanchristo
Copy link
Member

ryanchristo commented Aug 31, 2022

Can you add the grpc endpoint test as well? I overlooked this in the last pull request implementing the query.

@ryanchristo ryanchristo merged commit 07cc14f into main Aug 31, 2022
@ryanchristo ryanchristo deleted the ty/1435-all_balances_cmd branch August 31, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query command for query all balances
3 participants