Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: opening a new terminal isn't necessary #1592

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

justinlewis
Copy link
Contributor

@justinlewis justinlewis commented Nov 7, 2022

Description

Closes: #XXXX

In the Linux section, the last step to run 'regen version' doesn't seem to require opening a new terminal. I was able to do this in the same session. This is a small change but I thought it would just make it a little be clearer.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

In the Linux section, the last step to run 'regen version' doesn't seem to require opening a new terminal. I was able to do this in the same session. This is a small change but I thought it would just make it a little be clearer.
@justinlewis justinlewis requested a review from a team November 7, 2022 01:31
@ryanchristo ryanchristo added the backport/v4.1.x backport to release/v4.1.x branch label Nov 7, 2022
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @justinlewis !

@ryanchristo ryanchristo changed the title docs: Opening a new terminal isn't necessary. docs: opening a new terminal isn't necessary Nov 7, 2022
@ryanchristo ryanchristo merged commit 76a51ed into regen-network:main Nov 7, 2022
mergify bot pushed a commit that referenced this pull request Nov 7, 2022
Co-authored-by: Ryan Christoffersen <[email protected]>
(cherry picked from commit 76a51ed)
@justinlewis justinlewis deleted the patch-1 branch November 7, 2022 18:35
ryanchristo pushed a commit that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v4.1.x backport to release/v4.1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants