build(deps): Update to v0.43.0-rc0 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
commented
Jun 28, 2021
app/regen/cmd/root.go
Outdated
| @@ -72,7 +72,7 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) { | |||
| return err | |||
| } | |||
|
|
|||
| return server.InterceptConfigsPreRunHandler(cmd) | |||
| return server.InterceptConfigsPreRunHandler(cmd, "", nil) | |||
There was a problem hiding this comment.
This is actually an undocumented breaking change between beta1 and rc0. I created cosmos/cosmos-sdk#9592
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 61.01% 61.08% +0.06%
==========================================
Files 51 51
Lines 3317 3325 +8
==========================================
+ Hits 2024 2031 +7
- Misses 1029 1030 +1
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. |
amaury1093
commented
Jun 28, 2021
clevinson
approved these changes
Jun 28, 2021
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change