Skip to content

Added Environment="DAEMON_LOG_BUFFER_SIZE=512" #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DanielMagro97
Copy link

Without this environment variable, longer logs from the node, such as those from queries, can crash Cosmovisor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Without this environment variable, longer logs from the node, such as those from queries, can crash Cosmovisor
@ryanchristo
Copy link
Member

Thanks @DanielMagro97 for the pull request!

DAEMON_LOG_BUFFER_SIZE is no longer an environment variable in Cosmovisor v1.0. There was an issue in Cosmovisor v0.1 with reading longer logs and setting this variable to 512 was a recommended solution but this is no longer an issue with Cosmovisor v1.0. See cosmos/cosmos-sdk#9875.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #616 (65de38f) into master (68178f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   75.73%   75.73%           
=======================================
  Files         104      104           
  Lines       14236    14236           
=======================================
  Hits        10782    10782           
  Misses       2808     2808           
  Partials      646      646           
Flag Coverage Δ
experimental-codecov 75.73% <ø> (ø)
stable-codecov 67.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo closed this Nov 3, 2021
@DanielMagro97
Copy link
Author

Ah, I wasn't aware that this had been fixed, that's good news, thanks for the explanation @ryanchristo 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants