docs(x/data): update module overview #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 65.65% 72.45% +6.79%
==========================================
Files 178 183 +5
Lines 20216 22709 +2493
==========================================
+ Hits 13273 16454 +3181
+ Misses 5813 5038 -775
- Partials 1130 1217 +87
Flags with carried forward coverage won't be shown. Click here to find out more. |
technicallyty
approved these changes
Mar 21, 2022
| The `data` module emits events defined in [the Protobuf reference](./protobuf.html#regen-data-v1alpha2-events-proto). | ||
| The data module emits events defined in the Protobuf definitions: | ||
|
|
||
| - [regen.data.v1](https://buf.build/regen/regen-ledger/docs/main/regen.data.v1) |
There was a problem hiding this comment.
Suggested change
| - [regen.data.v1](https://buf.build/regen/regen-ledger/docs/main/regen.data.v1) | |
| - [regen.data.v1](https://buf.build/regen/regen-ledger/docs/main/regen.data.v1#regen.data.v1.EventAnchorData) |
should we link to the first event in the page?
There was a problem hiding this comment.
Hmmm... I was wondering the same thing since there is no event header but the event might change or a new event might be added before it. Maybe not likely but I think it's ok to leave as is for now.
Co-authored-by: Tyler <[email protected]>
clevinson
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #889
Update data overview and protobuf links.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:prefix in the PR title