Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'error event has already been emitted on the socket' in the console window #894

Closed
adrian3k opened this issue Feb 10, 2025 · 10 comments
Closed
Labels

Comments

@adrian3k
Copy link

Hi rejetto,
first of all - thanks for your great work, using software for years (earlier hfs2)

(node:6072) Warning: An error event has already been emitted on the socket. Please use the destroy method on the socket while handling a 'clientError' event.
(Use hfs --trace-warnings ... to show where the warning was created)

This message showed up few times (3 or 4) for the current release version.
I'm not sure how is this triggered, but haven't found any related 'things I was doing' arount the time it popped out inside console window.

If I could provide some additional info - please point to what would be helpful!

@rejetto
Copy link
Owner

rejetto commented Feb 10, 2025

i'm quite sure that warning is harmless, but surely i'd like to solve it.
but it will hardly be possible unless i'm able to easily reproduce the problem.
maybe you weren't doing anything to trigger it because it's about network activity of your users.

what version are you using?
did you see this message with previous versions?

@adrian3k
Copy link
Author

@rejetto current version, that is 0.55.4 - noticed this in the newest version only
during that time no users were around the server (logs empty), maybe it's related to port-scanners from cn/ru/us? the message doesn't say much - would dig deeper if I would know what it can be related with :D

sorry for this question in this topic - wanted to ask if there is a way to 'not refresh' IP'S (in Logs) that are already banned (or add some icon/text/color for banned ones)?

@rejetto
Copy link
Owner

rejetto commented Feb 10, 2025

that's newest stable version, but there's beta too.
logs don't include everything, they include only actual http requests, and can even exclude some based on the configuration.

sorry for this question in this topic - wanted to ask if there is a way to 'not refresh' IP'S (in Logs) that are already banned (or add some icon/text/color for banned ones)?

i'm not understanding. can you please open a different discussion/issue?

@adrian3k
Copy link
Author

I've added the parameter --trace-warnings to the executable, will add if something new pops out :D

@rejetto
Copy link
Owner

rejetto commented Feb 15, 2025

good idea.
I'm not sure that will actually work, as it's not me managing the "trace-warnings" thing, and never used it, but it's worth a try.

@rejetto
Copy link
Owner

rejetto commented Feb 20, 2025

how often does this happen?

another report: #670 (reply in thread)

@rejetto
Copy link
Owner

rejetto commented Feb 20, 2025

ok i've found out proof that is harmless and i will try to mute it in the next release, but cannot test the fix because i don't know how to reproduce it

@adrian3k
Copy link
Author

until this day had maybe 3-4 times, since added the parameter - haven't noticed yet

@rejetto
Copy link
Owner

rejetto commented Feb 20, 2025

ok, thanks.
the "trace" parameter is not supposed to hide it, so it just didn't happen.
version 0.56 should actually hide it, instead.

@adrian3k
Copy link
Author

and yesterday it showed again in the console window..
but even with added --trace-warnings to the executable
nothing showed inside the console window / debug.log or any other file..

but if it looks like 'harmless / unknown info' then I'll just ignore it :D
nothing happened around the time (connection/logon/refreshed IP in listing) - maybe the IP refreshed again after the message, but it was banned anyway :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants