Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #160

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Sep 17, 2022
@MichaelDeBoey
Copy link
Member Author

Seems like Cypress is mad 🤔😢

@mcansh
Copy link
Contributor

mcansh commented Sep 18, 2022

looks like jest dom uses nullish coalescing and cypress/webpack isn't a fan

@machour
Copy link
Collaborator

machour commented Sep 18, 2022

That nullish coalescing have been in testing dom for a long time.
Maybe try rolling back the cypress upgrade?

@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch 2 times, most recently from ed81c25 to 3782cb3 Compare September 19, 2022 09:08
@MichaelDeBoey MichaelDeBoey marked this pull request as draft September 19, 2022 09:08
@MichaelDeBoey
Copy link
Member Author

It seems like the problem is with @testing-library/dom v8.18.0 and above (which is a known problem: testing-library/dom-testing-library#1169), so I pinned it's version (for now)

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review September 19, 2022 09:21
@MichaelDeBoey MichaelDeBoey merged commit ebfa52b into remix-run:main Sep 19, 2022
@MichaelDeBoey MichaelDeBoey deleted the update-dependencies branch September 19, 2022 09:33
@dev-xo
Copy link

dev-xo commented Sep 19, 2022

Thanks you for the PR @MichaelDeBoey, been struggling watching Cypress tests failing, was looking for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants