Get default ignoreRoot from ignore-by-default #779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the default ignoreRoot to a list obtained from the ignore-by-default package. See <https://github.com/novemberborn/ignore-by-default>. This allows nodemon to tap into a shared list of directories it should ignore when watching for changes. E.g. compared to the original list it's already been extended with `.nyc_output` and `coverage` directories.
|
@novemberborn just wanted to drop a note - I'm aware of your two PRs <3 I need to grab some time to get this merged in, and work out why the travis is failing (though it's likely to be the sheer number and scary race conditions in the tests!). |
|
@remy thanks for the update! |
|
merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm adding
--watchsupport to AVA. Like nodemon it uses Chokidar to watch for changes, and like nodemon it should ignore non-code directories. Initially I copied theignoreRootconfig from here but it seemed like the list of directories to ignore should be in a package of its own. That way multiple projects can share good defaults 💯This PR switches the default
ignoreRootto a list obtained from theignore-by-defaultpackage. Compared to the original list in nodemon this adds.nyc_outputandcoveragedirectories.I marked this as a
refactor, but maybe it should be afeatureinstead. If so maybe theignore-by-defaultdependency should be pinned to an exact release so changes won't impact nodemon.This requires #778 to land first, otherwise that bug causes test breakage in this PR.