Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOLD FOR RELEASE Custom domains for EC #3116
HOLD FOR RELEASE Custom domains for EC #3116
Changes from 4 commits
ebaec1c
2ae91fa
c4835c5
e565e7b
28d0a4f
40acb33
891c060
1a23dbc
f4e453c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this in the custom domains for ec google doc. Not sure if there's more to add here (I guess it's self-explanatory why you'd want them to use the same custom domains for these services?).
I also left out the details about how exactly they are passed to KOTS (values in the helmchart resource), but can add that in if you think vendors would want to know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how it's passed isn't important. what KOTS does with it could be, depending on how much detail we want to go into. KOTS makes calls to replicated.app to check for updates, so that one is more self-explanatory. proxy.registry.com is a bit more confusing because different things happen. image names are automatically rewritten with the custom domain for k8s manifests and v1beta1 helm charts. for v1beta2, the vendor should have used the custom domain themselves. and then the custom domain is always used in the image pull secret(s) that is created by KOTS.
not saying any or all of that is necessary, but just filling you in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's good to know. We could consider (maybe as a different PR) updating the overview of the custom domains feature to make sure we have a good explanation of how/when the different endpoints are hit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i configure a custom domain now, i don't have to do the txt records anymore. separate from this pr, but would be worth asking VP about that. those steps still show in the configure a custom domain modal, but i don't think you really need the txt records now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I had a similar thought. Asked here https://replicated.slack.com/archives/CEEFDQURM/p1742315489907039
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed the txt record thing is still the backup option if http validation doesn't work. reworded this a bit to flip it aroundJust kidding. There's a new response from Dmitriy that I missed. Reworking againsuccess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your company throughout too (i assume most people's domain is their company name, not their app name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ this info about TXT records seemed a little random/in the weeds for an Overview. I also wasn't entirely sure if creating TXT records is still required or if the automatic http verification takes care of it, so I just removed this content
I did move the "The TXT records can be removed after the verification is complete" part over to be an optional step in the relevant procedure in Using Custom Domains