-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first pass at MongoDB Atlas via AWS #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR starts support for the MongoDB provider. The construct supports creating either a shared or serverless single region Atlas cluster backed by AWS. And the
access
module manages network and permissions for the cluster.Future Work
create_admin
variableAdditional Notes
The
access_rules
are meant to reference IAM role names within a project. For example, if you use "fastapi-lambda" as the role name in the rule, that could reference "${var.project}-fastapi-lambda-{var.environment}-${var.namespace}" depending on your naming convention. I was looking to implement, but it doesn't seem like that's supported. Terraform has atemplatefile
but not an equivalent function for working with in memory string templates. And there is a data source with thetemplate
provider but that has been deprecated in favor of thetemplatefile
function.