Skip to content
This repository was archived by the owner on Feb 27, 2025. It is now read-only.

Proper phpBB Support #58

Closed
wants to merge 1 commit into from
Closed

Proper phpBB Support #58

wants to merge 1 commit into from

Conversation

Dark1z
Copy link

@Dark1z Dark1z commented Apr 25, 2020

This supports :

  • Post Editor.
  • Quick Post Reply Editor.
  • Signature Editor.
  • Support phpBB extensions which replaces Default Text Editor buttons.
  • Universal Button position to support various phpBB styles & extensions.

Best regards 👍

rodber added a commit that referenced this pull request Aug 26, 2020
@rodber
Copy link
Owner

rodber commented Aug 26, 2020

What I don't like about this change is that you made a button with styling, so it doesn't preserve the phpBB form styling adding another layer of customization needed for those who don't want the styling you used. The default PUP buttons should be simple + fit the target editor, customization on top of it should be achieved using HTML attributes, as shown here: https://v3-docs.chevereto.com/extend/popup-upload-plugin.html

In any case, I've improved the PUP code to play better with phpBB default styling.

Thanks for your help!

@rodber rodber closed this Aug 26, 2020
@Dark1z
Copy link
Author

Dark1z commented Aug 26, 2020

Ok. thanks. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants