Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PHP versions of Actions CI in Laravel 6 and 7. #130

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

tobigumo
Copy link

Description of the change

Laravel 6 and 7 requires PHP 7.2 - 8.0, so exclude all PHP versions after 8.1 on GitHub Actions CI.
https://laravel.com/docs/master/releases#support-policy

Seeing #129 CIs failing, I created it as another PR.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Laravel 6 and 7 requires php 7.2 - 8.0, so exclude all php versions after 8.1
@tobigumo tobigumo changed the title Fixing the PHP version of Actions CI in Laravel 6 and 7. Fixing PHP versions of Actions CI in Laravel 6 and 7. Mar 17, 2022
@danielmorell
Copy link
Collaborator

Thank you @tobigumo for that link, and the PR. I was looking at the composer.json file yesterday for both v6 and v7. The PHP requirement includes PHP 8.1. However, it was clear that they have issues when trying to run on PHP 8.1.

@danielmorell danielmorell changed the base branch from master to rollbar-v3 March 17, 2022 10:07
@danielmorell danielmorell merged commit 5ba2b4b into rollbar:rollbar-v3 Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants