Fix base_controller build #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @santerioksanen for fixing this and the new github workflow 👍 The compiler on Ubuntu 20.04 is actually warning about
The reason this might have been treated as a warning on Ubuntu 20.04 but now as an error on Ubuntu 22.04 could be due to differences in the compiler or compiler settings between the two Ubuntu versions. It's possible that the compiler in Ubuntu 22.04 is stricter about type mismatches and now treats them as errors by default, whereas the compiler in Ubuntu 20.04 may have been more lenient. Anyway it is good that your PR fixes this issue Closes #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #89, I couldn't build the base_controller with PlatformIO.
This PR:
The change in diffbot_base/scripts/base_controller/lib/base_controller/base_controller.h I am not totally sure of, but with the change in place I am able to build and run the project.