Don't use libdnf5 as a dependency #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to restrict the version of `libdnf` dependency to not use the `libdnf >= 5.0.0` with different API. Unfortunately, the `dnf5` package providing such a `libdnf` was already released, so it is not enough just to change the provide in the `dnf5` package.
|
I have nothing against to merge the PR, but if I am not mistaken the issue was resolved by rpm-software-management/dnf5#601. |
Unfortunately it's not enough as microdnf picks the older available dnf5 package from the repository which is still providing the |
|
Correct |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to restrict the version of
libdnfdependency to not use thelibdnf >= 5.0.0with different API. Unfortunately, thednf5package providing such alibdnfwas already released, so it is not enough just to change the provide in thednf5package.