Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move {raster} and {terra} to Suggests #943

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Mar 3, 2025

Follow-up to #942

I couldn't use the same approach because I didn't find the documentation in terra for automatic conversion raster -> terra like the useful sf::st_as_sf().

  • Avoid using {raster} in examples
  • Update CI to avoid deprecation warnings

@olivroy olivroy marked this pull request as ready for review March 3, 2025 19:06
@schloerke schloerke changed the title Replace raster with terra refactor: Replace {raster} with {terra} Mar 4, 2025
DESCRIPTION Outdated
rlang,
RColorBrewer,
scales (>= 1.0.0),
sf (>= 0.9-6),
stats,
terra (>= 1.6-3),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep {terra} as a Suggests? To me, it's similar to {hexbin} being suggested by {ggplot2}.

If a package w/ install difficulties is not critical path to the main package, I like to make the package a Suggest dependency when possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(If so, this will require a few reverts to rlang::check_installed("terra")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's do this! Could you run revdep checks after merge? I could help if some revdeps are failing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run revdep checks after merge?

Sure, np! I can also run it on this branch and push back results, if you'd like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏃

@olivroy olivroy changed the title refactor: Replace {raster} with {terra} refactor: move {raster} and {terra} to Suggests Mar 4, 2025
@jcheng5
Copy link
Member

jcheng5 commented Mar 5, 2025

I will leave the reviewing to @schloerke but I just wanted to say thank you, @olivroy, for these great contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants