-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move {raster}
and {terra}
to Suggests
#943
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 15da72f.
{raster}
with {terra}
DESCRIPTION
Outdated
rlang, | ||
RColorBrewer, | ||
scales (>= 1.0.0), | ||
sf (>= 0.9-6), | ||
stats, | ||
terra (>= 1.6-3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to keep {terra}
as a Suggests? To me, it's similar to {hexbin}
being suggested by {ggplot2}
.
If a package w/ install difficulties is not critical path to the main package, I like to make the package a Suggest
dependency when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(If so, this will require a few reverts to rlang::check_installed("terra")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's do this! Could you run revdep checks after merge? I could help if some revdeps are failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run revdep checks after merge?
Sure, np! I can also run it on this branch and push back results, if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏃
{raster}
with {terra}
{raster}
and {terra}
to Suggests
I will leave the reviewing to @schloerke but I just wanted to say thank you, @olivroy, for these great contributions! |
Follow-up to #942
I couldn't use the same approach because I didn't find the documentation in terra for automatic conversion
raster
->terra
like the usefulsf::st_as_sf()
.{raster}
in examples