-
Notifications
You must be signed in to change notification settings - Fork 175
Recommend rust-analyzer vscode extension #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Can you also update the README in .vscode
to match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will wait for another reviewer, incase there's anything I missed.
I hope it's not rude to piggyback the second commit. I was testing the vscode debugging and noticed the deprecation warning about that launch config property "runToMain". Thanks for being so quick to review! Edit: I tested the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope it's not rude to piggyback the second commit.
That's fine by me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too. Thanks.
bors r+
Configuration problem: |
Looks like all the other have been merged with the button, so I'll just do that here. |
Thanks for doing that. I haven’t been around in a minute, so hadn’t noticed the deprecation. 👍 |
RLS and its extension have been deprecated as rust-analyzer has become the official language server for Rust.