Skip to content

Recommend rust-analyzer vscode extension #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Recommend rust-analyzer vscode extension #114

merged 2 commits into from
Oct 2, 2022

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Oct 2, 2022

RLS and its extension have been deprecated as rust-analyzer has become the official language server for Rust.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

Please see the contribution instructions for more information.

Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Can you also update the README in .vscode to match?

newAM
newAM previously approved these changes Oct 2, 2022
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will wait for another reviewer, incase there's anything I missed.

@senekor
Copy link
Contributor Author

senekor commented Oct 2, 2022

I hope it's not rude to piggyback the second commit. I was testing the vscode debugging and noticed the deprecation warning about that launch config property "runToMain".

Thanks for being so quick to review!

Edit: I tested the "runToEntryPoint": "main" with the OpenOCD launch config and it works. I'm having some trouble with the QEMU one, but I think those issues are unrelated.

Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it's not rude to piggyback the second commit.

That's fine by me :)

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too. Thanks.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

Configuration problem:
bors.toml: not found

@newAM
Copy link
Member

newAM commented Oct 2, 2022

Looks like all the other have been merged with the button, so I'll just do that here.

@newAM newAM merged commit 627ac5c into rust-embedded:master Oct 2, 2022
@rubberduck203
Copy link
Contributor

I hope it's not rude to piggyback the second commit. I was testing the vscode debugging and noticed the deprecation warning about that launch config property "runToMain".

Thanks for being so quick to review!

Edit: I tested the "runToEntryPoint": "main" with the OpenOCD launch config and it works. I'm having some trouble with the QEMU one, but I think those issues are unrelated.

Thanks for doing that. I haven’t been around in a minute, so hadn’t noticed the deprecation. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants