This repository was archived by the owner on Jan 24, 2022. It is now read-only.
Try combining some steps to speed up CI #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
therealprof
force-pushed
the
simplify-ci
branch
from
cd79e48 to
c4d7b69
Compare
.github/workflows/ci.yml
Outdated
| @@ -27,10 +24,20 @@ jobs: | |||
| with: | |||
| profile: minimal | |||
| toolchain: ${{ matrix.rust }} | |||
| target: ${{ matrix.TARGET }} | |||
| target: thumbv6m-none-eabi thumbv7m-none-eabi thumbv7em-none-eabi thumbv7em-none-eabihf thumbv8m.main-none-eabi | |||
There was a problem hiding this comment.
I don't think this action supports lists actions-rs/toolchain#62
There was a problem hiding this comment.
It might be easiest to just invoke rustup manually, it can take a list of targets to install
There was a problem hiding this comment.
Yes indeed. I'm already working on it.
Signed-off-by: Daniel Egger <[email protected]>
therealprof
force-pushed
the
simplify-ci
branch
from
c4d7b69 to
65fe321
Compare
|
Hm, no benefit here wall clock wise. But we're using way less builders which might be benefitial anyway. |
|
We could also collapse the Clippy and rustfmt builders into one |
|
Yes we could but I actually prefer them to be separate because that makes it easier for me to add them to other crates. 😅 |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Egger [email protected]