Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't expose registers clidr, ctr, ccsidr, csselr to ARMv6-M targets #53

Merged
merged 2 commits into from
Jun 30, 2017

Conversation

japaric
Copy link
Member

@japaric japaric commented Jun 29, 2017

as these are only available on ARMv7-M devices

as these are only available on ARMv7-M devices

closes #46
@japaric japaric added this to the 0.3.0 milestone Jun 29, 2017
@japaric
Copy link
Member Author

japaric commented Jun 30, 2017

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit c0e7dcb has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit c0e7dcb with merge c0e7dcb...

@homunkulus
Copy link
Contributor

💔 Test failed - status-travis

@japaric
Copy link
Member Author

japaric commented Jun 30, 2017

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit 58b5367 has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit 58b5367 with merge 04283fa...

japaric pushed a commit that referenced this pull request Jun 30, 2017
don't expose registers clidr, ctr, ccsidr, csselr to ARMv6-M targets

as these are only available on ARMv7-M devices
@homunkulus
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: japaric
Pushing 04283fa to master...

@homunkulus homunkulus merged commit 58b5367 into master Jun 30, 2017
@japaric japaric deleted the gh46 branch June 30, 2017 17:32
adamgreig pushed a commit that referenced this pull request Jan 12, 2022
this commit adds LLD support by removing all INFO sections. LLD kind of supports INFO in the form of
NOLOAD but when the linker script contains NOLOAD sections LLD emits a binary with false `size`
information: for example, it reported a fake increase of 20KB in .text and a fake increase of 1KB in
.bss when compiling a program that only allocates a single Box.

As the INFO sections are gone we can no longer support the stack overflow protection added in #43 so
all the other related changes, like making _stack_start overridable, have been removed as well.
If you want to continue using stack overflow protection you can stick to v0.3.x.

As the .debug_gdb_scripts output section has been removed from the linker script these changes will
only reliably support both LD and LLD if/when rust-lang/rust#49728 lands.

closes #53
reitermarkus pushed a commit to reitermarkus/cortex-m that referenced this pull request May 4, 2022
this commit adds LLD support by removing all INFO sections. LLD kind of supports INFO in the form of
NOLOAD but when the linker script contains NOLOAD sections LLD emits a binary with false `size`
information: for example, it reported a fake increase of 20KB in .text and a fake increase of 1KB in
.bss when compiling a program that only allocates a single Box.

As the INFO sections are gone we can no longer support the stack overflow protection added in rust-embedded#43 so
all the other related changes, like making _stack_start overridable, have been removed as well.
If you want to continue using stack overflow protection you can stick to v0.3.x.

As the .debug_gdb_scripts output section has been removed from the linker script these changes will
only reliably support both LD and LLD if/when rust-lang/rust#49728 lands.

closes rust-embedded#53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants