Add split-switches-pass to AFL++ instrumentation

[R9295]

the split-switches-pass was missing for AFL++'s cmplog instrumentation. And also, the order of the passes matters so I re-ordered them in the same order as AFL++'s afl-cc.c

[smoelius]

Thanks!

I re-ordered them in the same order as AFL++'s afl-cc.c

Could you point me to the lines in that file you are using to determine the order? It will be helpful for others who find this PR, and for future contributors should additional passes need to be added.

[R9295]

Sure:
https://github.com/AFLplusplus/AFLplusplus/blob/stable/src/afl-cc.c#L3397-L3534

edit:
The missing pass
https://github.com/AFLplusplus/AFLplusplus/blob/stable/src/afl-cc.c#L3459-L3460

[vanhauser-thc]

Lgtm thanks for fixing aarnav

[smoelius]

Sorry if this is a dumb question, but how did you choose where in the order to put this plugin (SanitizerCoveragePCGUARD.so)?

[R9295]

https://github.com/AFLplusplus/AFLplusplus/blob/stable/src/afl-cc.c#L3482-L3484

[vanhauser-thc]

the order is the correct one. first cmplog should know about the switch compare, then we split the switches so the coverage can easily see the differences in comparing the switches - then the coverage instrumentation. later the instrumentations of integer/float/string/pointer comparisons.

[R9295]

@smoelius I think this is a bug in the latest nightly. experiencing this on another project too, locally.

[smoelius]

@smoelius I think this is a bug in the latest nightly. experiencing this on another project too, locally.

Can I ask which one?

[smoelius]

Published in version 0.15.12.

[R9295]

@smoelius I guess you figured out the root cause:
mmastrac/rust-ctor#309

[smoelius]

@smoelius I guess you figured out the root cause: mmastrac/rust-ctor#309

I'm not sure, TBH.