Skip to content
This repository was archived by the owner on Dec 1, 2023. It is now read-only.

Buggy deriving of RustcEncode when multiple module with a method encode() are in scope #151

Closed
NougatRillettes opened this issue Apr 12, 2016 · 3 comments · Fixed by rust-lang/rust#32908
Closed

Buggy deriving of RustcEncode when multiple module with a method encode() are in scope #151

NougatRillettes opened this issue Apr 12, 2016 · 3 comments · Fixed by rust-lang/rust#32908

Comments

@NougatRillettes
Copy link

As shown in this MCVE (by SO user ker) deriving of RustcEncode leads to error E0034 if there is any Trait with an encode() method in Scope.

As shown here it can be troublesome when using both rustc-serialize and radix_tree crates.
@NougatRillettes NougatRillettes changed the title Buggy deriving of RustcENcode when multiple module with a method encode() are in scope Buggy deriving of RustcEncode when multiple module with a method encode() are in scope Apr 12, 2016
@NougatRillettes
Copy link
Author

Possibly related to: #61. But I have no idea how derive works.

@oli-obk oli-obk mentioned this issue Apr 12, 2016
Merged
bors added a commit to rust-lang/rust that referenced this issue Apr 14, 2016
@bors
Auto merge of #32908 - oli-obk:hygienic_derive_encodable, r=alexcrichton
073a09f 
prevent other `encode` methods from breaking `derive(RustcEncodable)`

fixes rust-lang-deprecated/rustc-serialize#151
@cholcombe973
Copy link

I unfortunately hit this bug also a few minutes ago

@NougatRillettes
Copy link
Author

It is now allegedly fixed by commit to rust-lang by @oli-obk.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent other encode methods from breaking derive(RustcEncodable) oli-obk/rust
2 participants
@NougatRillettes @cholcombe973