Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "nightly" feature #136

Closed
Ericson2314 opened this issue Dec 10, 2018 · 5 comments · Fixed by #138
Closed

Remove "nightly" feature #136

Ericson2314 opened this issue Dec 10, 2018 · 5 comments · Fixed by #138

Comments

@Ericson2314
Copy link
Contributor

I believe it is dead code now? Somewhere in the switching from heap to inline-only it became redundant, it looks like.

@Ericson2314 Ericson2314 changed the title Remove nightly feature Remove "nightly" feature Dec 10, 2018
@KodrAus
Copy link
Contributor

KodrAus commented Jan 2, 2019

Thanks for the suggestion @Ericson2314! This seems reasonable to me, since the nightly feature isn't considered stable.

Would you like to submit a PR?

@Ericson2314
Copy link
Contributor Author

I'm a bit swamped with other things (and don't use travis much myself). Just was reading this again and noticed.

@KodrAus
Copy link
Contributor

KodrAus commented Jan 3, 2019

Ah no worries 👍 If anybody would like to contribute this it'd be much appreciated!

@Ericson2314
Copy link
Contributor Author

If there was just that one line, I would have done it myself :). I think what's left is:

@KodrAus
Copy link
Contributor

KodrAus commented Jan 7, 2019

Ah thanks! I thought we'd already removed the nightly feature from CI but didn't actually check.

I'll chase up these extra bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants