Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the heap impl now that inline is always available #132

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Remove the heap impl now that inline is always available #132

merged 2 commits into from
Nov 1, 2018

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Nov 1, 2018

For #131

Now that we've bumped past 1.22.0 as the minimum rustc version I think we can remove the heap_impl altogether and the infrastructure we used to detect a compatible compiler at build-time.

cc @Kimundi

@KodrAus
Copy link
Contributor Author

KodrAus commented Nov 1, 2018

r? @dtolnay

The build script was originally added in #103 to switch between the heap and inline impls if we happened to be on a compiler newer or equal to 1.22.0.

Also cc @anp

dtolnay
dtolnay approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! Thanks for cleaning this up.

@anp
Copy link
Contributor

anp commented Nov 1, 2018

swoon

@KodrAus KodrAus merged commit fa421ef into rust-lang-nursery:master Nov 1, 2018
@KodrAus KodrAus deleted the feat/remove-heap-impl branch November 1, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KodrAus @anp @dtolnay