Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use mmap on macOS #302

Merged
merged 11 commits into from
Mar 10, 2020
+44 −2
Merged

Don't use mmap on macOS #302

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab06897
Add regression test for SIGPIPE on macOS
Aaron1011 Mar 9, 2020
b585df8
Disable `mmap` on macOS
Aaron1011 Mar 9, 2020
ed000ab
Run `cargo fmt`
Aaron1011 Mar 9, 2020
23328fe
Remove unused variable name
Aaron1011 Mar 9, 2020
86e4a37
s/macos/darwin/
Aaron1011 Mar 9, 2020
99a78f4
Move macOS test to its own file
Aaron1011 Mar 9, 2020
997edab
Move macOS dSYM test to its own directory
Aaron1011 Mar 10, 2020
3c90856
Remove 'darwin' check to verify new test
Aaron1011 Mar 10, 2020
e482844
Fix rustfmt
Aaron1011 Mar 10, 2020
cadd87c
Re-add darwin check
Aaron1011 Mar 10, 2020
3cc3e07
Move macOS test to a non-workspace crate
Aaron1011 Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable mmap on macOS 
See rust-lang/rust#45866 for more details
@Aaron1011
Aaron1011 committed Mar 9, 2020

Verified

This commit was signed with the committer’s verified signature.
Aaron1011 Aaron Hill
GPG key ID: B4087E510E98B164
Verified
Learn about vigilant mode
commit b585df804fed5b2070669e3110561adc4a403923
4 changes: 3 additions & 1 deletion crates/backtrace-sys/build.rs
View file
Original file line number Diff line number Diff line change
@@ -36,7 +36,9 @@ fn main() {

// `mmap` does not exist on Windows, so we use
// the less efficient `read`-based code.
if target.contains("windows") {
// Using `mmap` on macOS causes weird isseus - see
// https://github.com/rust-lang/rust/pull/45866
if target.contains("windows") || target.contains("macos") {
build.file("src/libbacktrace/read.c");
} else {
build.file("src/libbacktrace/mmapio.c");