-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add announcement post for 1.16 #153
Conversation
[can show off your TravisCI or Appveyor badges]: https://github.com/rust-lang/cargo/pull/3546 | ||
In addition, both Cargo and crates.io [understand categories]. Unlike keywords, which are free-form, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably deserves a more prominent mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be up at the top then, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of this section? I'm not sure. It just felt a bit buried.
But reflecting more, I'm not sure the front-end experience is quite where we want it to make a "big splash" here, so maybe a passing mention is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. I'm happy to move it wherever, to be honest.
Looks great! I don't think it's too long -- just plenty to talk about :-) |
_posts/2017-03-16-Rust-1.16.md
Outdated
[This now happens nearly everywhere]: https://github.com/rust-lang/rust/pull/38927 | ||
[some other related improvements]: https://github.com/rust-lang/rust/pull/38154 | ||
Finally, `Self` can now appear [in impl headers] and [in struct expressions]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self
in impl headers rarely works in 1.16
The final piece was landed in rust-lang/rust#40008, so it will be fully available only in 1.17
_posts/2017-03-16-Rust-1.16.md
Outdated
@@ -201,11 +201,6 @@ results in a significant improvement in these sorts of diagnostics. | |||
[This now happens nearly everywhere]: https://github.com/rust-lang/rust/pull/38927 | |||
[some other related improvements]: https://github.com/rust-lang/rust/pull/38154 | |||
Finally, `Self` can now appear [in impl headers] and [in struct expressions]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveklabnik
My comment was only about impl headers, Self
in struct expressions (Self { a: 10 }
) is fully supported in 1.16
This isn't 100% ready to ship, as I need to run thanks still, so the number is wrong.
I wonder if it's not a bit too long, especially the diagnostic bit.
r? @rust-lang/core