Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bitcode from iOS / watchOS #768

Closed

Conversation

keith
Copy link
Contributor

@keith keith commented Jan 5, 2023

Starting with Xcode 14 Apple deprecated bitcode and stopped accepting applications built with it.

Starting with Xcode 14 Apple deprecated bitcode and stopped accepting
applications built with it.
@keith
Copy link
Contributor Author

keith commented Jan 5, 2023

realistically it might be the case that this isn't the right time to do this, since technically folks could use a newer rust + older Xcode until Apple stops accepting apps from Xcode 13 (which I think normally happens around spring). I discovered this working on rust-lang/rust#106476 but I found another workaround for that for now

@JohnTitor
Copy link
Member

realistically it might be the case that this isn't the right time to do this, since technically folks could use a newer rust + older Xcode until Apple stops accepting apps from Xcode 13 (which I think normally happens around spring).

Yeah, I'm concerned about that too. So, at least that flag doesn't produce an error on a newer toolchain, right? Then, maybe we should just add FIXME for now, and remove it when rustc drops the support for older Xcode, or Xcode starts to emit an error for it.

keith added a commit to keith/cc-rs that referenced this pull request Jan 5, 2023
As of Xcode 14 Bitcode is deprecated but Apple still accepts apps built
with bitcode if you're still using Xcode 13. Once Apple stops allowing
you to upload apps built with Xcode 13 this argument should be removed.

rust-lang#768
@keith keith mentioned this pull request Jan 5, 2023
@keith
Copy link
Contributor Author

keith commented Jan 5, 2023

Correct it still works fine because all tooling expects the build process to do a final bitcode strip step in the case you don't actually need bitcode. It's just the case I found in the compiler that tripped it up.

Updating the comment here #769 !

@keith keith closed this Jan 5, 2023
@keith keith deleted the ks/remove-bitcode-from-ios-watchos branch January 5, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants