Support where clauses on opaque types #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
force-pushed
the
opaque-where-clauses
branch
2 times, most recently
from
d891c65 to
ce1f9ad
Compare
nikomatsakis
requested changes
Jul 17, 2020
| /// AliasEq(T<U> = !T<U>). | ||
| /// WF(T<U>) :- WF(U: C). | ||
| /// Implemented(!T<U>: A). | ||
| /// Implemented(!T<U>: B). |
There was a problem hiding this comment.
So this seems right, but also sort of...incomplete, in that we never use these where clauses as hypotheses. I guess this is because we would want to do that in the well-formedness checking for the opaque type definition, which is not yet implemented?
There was a problem hiding this comment.
That was my thinking as well. I was thinking those checks would probably belong around here based on what we do for ADTs and trait impls. I figure we could save that for a follow-up PR.
nathanwhit
force-pushed
the
opaque-where-clauses
branch
from
ce1f9ad to
1d0f5a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR iterates upon #498 to try to address the review comments there.