Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TypeName and merge into TyKind #629

Merged
merged 6 commits into from
Oct 22, 2020
Merged

Conversation

jackh726
Copy link
Member

No description provided.

@matthewjasper
Copy link
Contributor

Let's see if bors will listen to me...
@bors r+

@bors
Copy link
Contributor

bors commented Oct 22, 2020

@matthewjasper: 🔑 Insufficient privileges: Not in reviewers

@jackh726
Copy link
Member Author

@bors r=matthewjasper

@bors
Copy link
Contributor

bors commented Oct 22, 2020

📌 Commit fd295d6 has been approved by matthewjasper

@bors
Copy link
Contributor

bors commented Oct 22, 2020

⌛ Testing commit fd295d6 with merge 420e937...

@bors
Copy link
Contributor

bors commented Oct 22, 2020

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing 420e937 to master...

@bors bors merged commit 420e937 into rust-lang:master Oct 22, 2020
@jackh726 jackh726 deleted the typename branch October 22, 2020 20:58
@camelid
Copy link
Member

camelid commented Oct 22, 2020

Hmm, this broke links in the docs but bors still merged it.

@camelid camelid mentioned this pull request Oct 22, 2020
@jackh726
Copy link
Member Author

@camelid we specifically don't block merge on linkcheck; we've seen false positives before and in general don't want it to hold up CI anyways

@camelid
Copy link
Member

camelid commented Oct 23, 2020

Ah, well the linkchecker caught that TypeName was referenced and thus the docs are out of date.

@daboross daboross mentioned this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants