Make the Generator trait well-known #723
Merged
+134
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Cameron <[email protected]>
jackh726
reviewed
Aug 22, 2021
| .clone() | ||
| .substitute(interner, &substitution); | ||
|
|
||
| let trait_id = db.well_known_trait_id(WellKnownTrait::Generator).unwrap(); |
There was a problem hiding this comment.
Side comment (don't need to change here, since it's done elsewhere), but we probably want to just not add clauses if this isn't defined rather than panicking.
|
@bors r+ |
|
📌 Commit ce31db8 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jackh726 There's quite a lot of cargo culting of code from function trait support which I don't fully understand, so I'd appreciate a close review.
As discussed on Zulip, this adds initial support for the Generator trait as a well-known trait. I'll work on
DispatchFromDynnext, but want to check I'm doing the right things first.