Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use utility function to compare the repr of floats #50

Merged
merged 1 commit into from
Aug 21, 2016
Merged

Conversation

japaric
Copy link
Member

@japaric japaric commented Aug 21, 2016

follow up of #43

r? @mattico

@mattico
Copy link
Contributor

mattico commented Aug 21, 2016

LGTM, though there's likely to be a merge conflict between this and #48. I can rebase that one if you want to merge this first.

@japaric
Copy link
Member Author

japaric commented Aug 21, 2016

I think we'll have to first sort out the soft float arm target test failure in #48 before it lands. Does merging this first sounds good to you?

@mattico
Copy link
Contributor

mattico commented Aug 21, 2016

Yes that makes sense.

On Sun, Aug 21, 2016, 11:47 AM Jorge Aparicio [email protected]
wrote:

I think we'll have to first sort out the soft float arm target test
failure in #48 #48 before
it lands. Does merging this first sounds good to you?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#50 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0Epl70DwSGHYEeVTnXUpLiPOP_bhV5ks5qiIEXgaJpZM4JpVLG
.

@japaric japaric merged commit 7811f92 into master Aug 21, 2016
@japaric japaric deleted the post-43 branch August 21, 2016 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants