Fix nm #84
Merged
Fix nm #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2016 19:04
the prefix was missing a '-', i.e. arm-linux-gnueabinm was being called. This also sets -e in run.sh to catch this sort of errors.
|
@homunkulus r+ |
|
📌 Commit 3b8dedd has been approved by |
|
@japaric is there a log of these failures somewhere? Does it look like the same sort of issue we were having with the gnueabihf targets? |
|
@mattico arm-unknown-linux-gnueabi I don't know if the other arm targets were also failing.
I'm not sure but the same intrinsics are failing, right? addsf3 and adddf3. |
|
Ah, but both the vs compiler_rt and vs gcc_s tests are failing so it's different. On gnueabihf only vs gcc_s was failing iirc. |
|
Ah, mips-gnu and mipsel-gnu were also failing 🙀. |
|
So there's probably a real issue somewhere. Not looking forward to debugging that... |
|
💔 Test failed - status-travis |
|
It might be a good idea to remove the add impl for now since it's still broken but the old tests didn't catch it. It might randomly fail if the U{32,64} quickcheck randomly generates a small denormal. |
Merged
|
@homunkulus try |
added 2 commits
September 30, 2016 20:20
|
@homunkulus r+ |
|
📌 Commit d0a57cb has been approved by |
|
@homunkulus r+ |
|
📌 Commit 89ebc46 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
84: Implement fmod r=japaric a=P1n3appl3 closes rust-lang#21 I replaced the `isnanf()` function from `fmodf()` with a call to the core function `is_nan()`. If there's a reason we needed to re-implement it then I can change that back. Also I couldn't figure out what to do in `src/lib.rs`. Is the `#[cfg(todo]` that I should be removing the one for `mod_euc()`? If so why is the equivalent one for the `f64` version still there? Co-authored-by: Joseph Ryan <[email protected]> Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were actually running
ci/run.shwithoutset -eand we were ignoring test failures and failed commands 🙀.This also undoes #48 which introduced test failures in addsf3 and adddf3 for the arm-unknown-linux-gnueabi target. Sorry @mattico!