Initial implementation of multitester #86
Merged
+41
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
@homunkulus r+ Thank you, @mattico 👍 |
|
📌 Commit 02140cd has been approved by |
japaric
pushed a commit
that referenced
this pull request
Oct 3, 2016
Initial implementation of multitester Implements part of #72. I wanted to work on this first because it should help me find the problem in the add implementation. Test failures now look like this: ``` __addsf3 - Args: 1 1264853201 rustc-builtins: Some(0) compiler_rt: Some(14950609) gcc_s: None __addsf3 - Args: 1 632426600 rustc-builtins: Some(0) compiler_rt: Some(0.00000000000000030889195) gcc_s: None __addsf3 - Args: 1 316213300 rustc-builtins: Some(0) compiler_rt: Some(0.0000000000000000000000000013696648) gcc_s: None [snip] thread 'float::add::tests::_test::__addsf3' panicked at '[quickcheck] TEST FAILED. Arguments: (1, 1)', /home/matt/.cargo/registry/src/github.lhy31512.workers.dev-1ecc6299db9ec823/quickcheck-0.3.1/src/tester.rs:118 ``` It currently prints all of the errors, if that's undesirable we'd need to remove the shrinkers or modify quickcheck.
|
☀️ Test successful - status-appveyor, status-travis |
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
86: Add log implementation. r=japaric a=leesdolphin Fixes rust-lang#23 Co-authored-by: Opal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of #72.
I wanted to work on this first because it should help me find the problem in the add implementation.
Test failures now look like this:
It currently prints all of the errors, if that's undesirable we'd need to remove the shrinkers or modify quickcheck.