Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide the thumbv* target files #88

Merged
merged 1 commit into from
Oct 3, 2016
Merged

hide the thumbv* target files #88

merged 1 commit into from
Oct 3, 2016

Conversation

japaric
Copy link
Member

@japaric japaric commented Oct 3, 2016

due to how Cargo works, the rustc-cfg in build.rs was picking our target
specifications rather than the one the user meant to use. Placing our
target files in any place other than the root of the Cargo project
avoids the issue.

due to how Cargo works, the rustc-cfg in build.rs was picking our target
specifications rather than the one the user meant to use. Placing our
target files in any place other than the root of the Cargo project
avoids the issue.
@japaric
Copy link
Member Author

japaric commented Oct 3, 2016

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit 0827f8c has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit 0827f8c with merge 0827f8c...

@homunkulus
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 0827f8c to master...

@homunkulus homunkulus merged commit 0827f8c into master Oct 3, 2016
@alexcrichton alexcrichton deleted the hide-thumbs branch October 14, 2016 18:50
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Feb 23, 2025
88: add license and other comments to existing files r=japaric a=erikdesjardins

re rust-lang#73

Co-authored-by: Erik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants