Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Z unpretty flags for the AST and the THIR #408

Closed
3 tasks done
LeSeulArtichaut opened this issue Feb 19, 2021 · 2 comments
Closed
3 tasks done

Add -Z unpretty flags for the AST and the THIR #408

LeSeulArtichaut opened this issue Feb 19, 2021 · 2 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Feb 19, 2021 •
edited
Loading

Proposal

Add a few -Z (perma-unstable) flags to dump a representation of the AST and THIR, akin to -Zunpretty=hir-tree for the HIR:

  • -Zunpretty=ast-tree and -Zunpretty=ast-tree,expanded for the AST
  • -Zunpretty=thir-tree for the THIR

Being able to dump those IRs is always useful when hacking on the compiler. Also, this is something we (the rustc-dev-guide WG) would like to have for rust-lang/rustc-dev-guide#1062, to be able to better teach those IRs.

Mentors or Reviewers

Implemented in rust-lang/rust#82304, looking for a reviewer

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@LeSeulArtichaut LeSeulArtichaut added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Feb 19, 2021
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Feb 19, 2021
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Feb 19, 2021
Merged
@estebank
Copy link

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Feb 19, 2021
@LeSeulArtichaut LeSeulArtichaut removed the to-announce Announce this issue on triage meeting label Feb 20, 2021
@LeSeulArtichaut LeSeulArtichaut added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Mar 3, 2021
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Mar 3, 2021
@LeSeulArtichaut LeSeulArtichaut removed the to-announce Announce this issue on triage meeting label Mar 3, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 4, 2021
@Dylan-DPC
Rollup merge of rust-lang#82304 - LeSeulArtichaut:unpretty-ast, r=spa…
e0ef270 
…storino

Add `-Z unpretty` flags for the AST

Implements rust-lang/compiler-team#408.
Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269.
cc rust-lang/rustc-dev-guide#1062
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 4, 2021
@bors
Auto merge of rust-lang#82304 - LeSeulArtichaut:unpretty-ast, r=spast…
7f32f62 
…orino

Add `-Z unpretty` flags for the AST

Implements rust-lang/compiler-team#408.
Builds on rust-lang#82269, but if that PR is rejected or stalls out, I can implement this without rust-lang#82269.
cc rust-lang/rustc-dev-guide#1062
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Mar 7, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Mar 11, 2021
@JohnTitor
Rollup merge of rust-lang#82860 - LeSeulArtichaut:unpretty-thir, r=sp…
2515638 
…astorino

Add `-Z unpretty` flag for the THIR

This adds a new perma-unstable flag, `-Zunpretty=thir-tree`, that dumps the raw THIR tree for each body in the crate.

Implements the THIR part of MCP rust-lang/compiler-team#408, helps with rust-lang/rustc-dev-guide#1062.
Depends on rust-lang#82495, blocked on that. Only the two last commits are added by this PR.
r? `@spastorino` cc `@estebank`
JohnTitor added a commit to JohnTitor/rust that referenced this issue Mar 11, 2021
@JohnTitor
Rollup merge of rust-lang#82860 - LeSeulArtichaut:unpretty-thir, r=sp…
26d4393 
…astorino

Add `-Z unpretty` flag for the THIR

This adds a new perma-unstable flag, `-Zunpretty=thir-tree`, that dumps the raw THIR tree for each body in the crate.

Implements the THIR part of MCP rust-lang/compiler-team#408, helps with rust-lang/rustc-dev-guide#1062.
Depends on rust-lang#82495, blocked on that. Only the two last commits are added by this PR.
r? ``@spastorino`` cc ``@estebank``
JohnTitor added a commit to JohnTitor/rust that referenced this issue Mar 11, 2021
@JohnTitor
Rollup merge of rust-lang#82860 - LeSeulArtichaut:unpretty-thir, r=sp…
f183a3e 
…astorino

Add `-Z unpretty` flag for the THIR

This adds a new perma-unstable flag, `-Zunpretty=thir-tree`, that dumps the raw THIR tree for each body in the crate.

Implements the THIR part of MCP rust-lang/compiler-team#408, helps with rust-lang/rustc-dev-guide#1062.
Depends on rust-lang#82495, blocked on that. Only the two last commits are added by this PR.
r? ```@spastorino``` cc ```@estebank```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@estebank @LeSeulArtichaut @rustbot