-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crates which create files in build scripts can't be cargobombed #157
Comments
At minimum we should allow (say) 100MB in |
In the case of LALRPOP it needs access to write into the source directory as it is an actual source file that gets created which rustc compiles afterwards. |
Got a link? Usually if you're generating source files you can use (was also talking about this to @tglman who creates temporary databases for testing) |
That's true, currently I just .gitignore it so I never see it but generating to https://github.com/gluon-lang/gluon/blob/master/parser/build.rs I assume cargobomb will work in that case?, as OUT_DIR is a place which must be writable for any compilation to work at all? |
Yup, |
Should let gluon be ran under cargobomb rust-lang/crater#157 but I think that regardless of that it is better to generate files outside of the source tree
Should let gluon be ran under cargobomb rust-lang/crater#157 but I think that regardless of that it is better to generate files outside of the source tree
Should let gluon be ran under cargobomb rust-lang/crater#157 but I think that regardless of that it is better to generate files outside of the source tree
I think gluon was blacklisted due the problem in rust-lang#157 but that has since been fixed in the crate itself so gluon now compiles (verified by running crater locally). Found because I started getting the warning from rust-lang/rust#57501 in gluon_vm.
Re-add gluon* to the crater list I think gluon was blacklisted due the problem in #157 but that has since been fixed in the crate itself so gluon now compiles (verified by running crater locally). Found because I started getting the warning from rust-lang/rust#57501 in gluon_vm.
For instance any crate using LALRPOP needs to generate a .rs file from the grammar file but due to the file system being read-only.
The text was updated successfully, but these errors were encountered: