Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a wrong word #369

Closed
wants to merge 1 commit into from
Closed

Fixed a wrong word #369

wants to merge 1 commit into from

Conversation

iamlockon
Copy link

@iamlockon iamlockon commented Feb 24, 2025

Please take a look at the changes, I believe it's a valid suggestion.

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting some action (such as code changes) from the PR author label Feb 24, 2025
@TonalidadeHidrica
Copy link
Contributor

Rather than that, I interpreted it as "pass the reference to the pattern" (from the scrutinee) because of the word pass.

@iamlockon
Copy link
Author

@TonalidadeHidrica Thanks for the comment. If you read L44 first (naturally), you might feel the same as I do.

@traviscross
Copy link
Contributor

Thanks for the suggestion. What's written is actually what's meant, though this PR has certainly caused us to think about how we could rewrite this sentence overall in a better way.

As a comparison, see the earlier use of the word "pass":

Here, in the pattern, we pass the outer shared reference in the scrutinee.

So then when we later say:

Here, because we pass the shared reference in the pattern...

The "in the pattern" is meant in the same way as the "in the pattern" subclause in the last use.

@iamlockon iamlockon deleted the patch-1 branch February 27, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: The marked PR is awaiting some action (such as code changes) from the PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants