Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clock_gettime for macOS 10.12+ #776

Closed
ekmartin opened this issue Sep 21, 2017 · 3 comments
Closed

clock_gettime for macOS 10.12+ #776

ekmartin opened this issue Sep 21, 2017 · 3 comments

Comments

@ekmartin
Copy link
Contributor

macOS 10.12 and Xcode 8 added support for clock_gettime and related functions. Would it be possible to add these to the macOS libc bindings?

I'd send a PR, but not sure how to do it conditionally since it doesn't seem like the OS version number is included in cfg.

Relevant: zeromq/libzmq#2175

@alexcrichton
Copy link
Member

Seems good to me to add! (PRs are more than welcome!)

@ekmartin
Copy link
Contributor Author

@alexcrichton: but would it be okay to add it to the general apple/mod.rs even if it's only supported in newer versions of macOS?

@alexcrichton
Copy link
Member

Yeah that's fine, this isn't the first symbol of its kind :)

bors added a commit that referenced this issue Sep 21, 2017
Add clock_gettime related functions to macOS

Fixes #776. The constants were retrieved on macOS 10.12.6. Tried adding `clock_nanosleep` too, but it doesn't seem like macOS' libc includes that yet.
bors added a commit that referenced this issue Sep 21, 2017
Add clock_gettime related functions to macOS

Fixes #776. The constants were retrieved on macOS 10.12.6. Tried adding `clock_nanosleep` too, but it doesn't seem like macOS' libc includes that yet.
bors added a commit that referenced this issue Sep 21, 2017
Add clock_gettime related functions to macOS

Fixes #776. The constants were retrieved on macOS 10.12.6. Tried adding `clock_nanosleep` too, but it doesn't seem like macOS' libc includes that yet.
@bors bors closed this as completed in #777 Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants