Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD10 support #1518

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Add FreeBSD10 support #1518

merged 1 commit into from
Sep 21, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Sep 16, 2019

This adds libc-test support for Freebsd10 and a CI build job that tests
FreeBSD10 with LIBC_CI only.

cc @asomers this is a follow up to #1491 .

This adds libc-test support for Freebsd10 and a CI build job that tests
FreeBSD10 with LIBC_CI only.
@rust-highfive
Copy link

@gnzlbg: no appropriate reviewer found, use r? to override

@asomers
Copy link
Contributor

asomers commented Sep 16, 2019

I still disagree with this PR on general principle: FreeBSD 10 is EOL so we shouldn't bother to support it anymore. I assume that reason to do it is that libstd still uses a FreeBSD 10 build host? If so, can we get them to upgrade their builder instead?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Sep 16, 2019

I assume that reason to do it is that libstd still uses a FreeBSD 10 build host?

libstd uses a FreeBSD10 build host, yes.

If so, can we get them to upgrade their builder instead?

Maybe someone can, but the only thing I can do is try to prevent libc from being broken on FreeBSD10 hosts until libstd migrates away from it so that broken libc's don't end up in libstd, and as a result all FreeBSD hosts end up broken.

@asomers
Copy link
Contributor

asomers commented Sep 16, 2019

Does the current situation result in libstd that is broken on FreeBSD 11 and 12 hosts, or only broken on FreeBSD 10 hosts?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Sep 16, 2019

Does the current situation result in libstd that is broken on FreeBSD 11 and 12 hosts, or only broken on FreeBSD 10 hosts?

The situation that happened a couple of weeks ago broke rustc on FreeBSD10 and 11 hosts. I think it was a consequence of us not testing FreeBSD10, because the libc/build.rs was broken for that host, and ended up picking up freebsd12 symbols, and that resulted in the broken rustc.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Sep 17, 2019

So I'm not sure what to do about this. If there isn't consensus then I think I'll just close it.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Sep 21, 2019

I'm merging this. If someone wants to put in the work of upgrading FreeBSD in rust-lang/rust upstream, they can do so, and let us know, and then I'll remove all of this. But until that happens, we should try to make sure that rust-lang/rust doesn't generate broken toolchains for FreeBSD targets.

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 21, 2019

📌 Commit 3843c7d has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Sep 21, 2019

⌛ Testing commit 3843c7d with merge f66ba4f...

bors added a commit that referenced this pull request Sep 21, 2019
Add FreeBSD10 support

This adds libc-test support for Freebsd10 and a CI build job that tests
FreeBSD10 with LIBC_CI only.

cc @asomers this is a follow up to #1491 .
@bors
Copy link
Contributor

bors commented Sep 21, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Sep 21, 2019

📌 Commit 3843c7d has been approved by gnzlbg

bors added a commit that referenced this pull request Sep 21, 2019
Add FreeBSD10 support

This adds libc-test support for Freebsd10 and a CI build job that tests
FreeBSD10 with LIBC_CI only.

cc @asomers this is a follow up to #1491 .
@bors
Copy link
Contributor

bors commented Sep 21, 2019

⌛ Testing commit 3843c7d with merge 58b2706...

@bors
Copy link
Contributor

bors commented Sep 21, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 58b2706 to master...

@bors bors merged commit 3843c7d into rust-lang:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants