-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vxWorks in libc-test #1543
Conversation
cc @n-salim |
libc-test/build.rs
Outdated
"_Vx_EVENTS_RSRC" | | ||
"_Vx_semaphore" | | ||
//Avaliable in Kernel space. | ||
"epoll_event" => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought epoll_event
was removed from the libc crate ?
libc-test/build.rs
Outdated
"passwd" | | ||
//the below definitions is part of public/private/ | ||
"_Vx_EVENTS_RSRC" | | ||
"_Vx_semaphore" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these private in the libc crate ? If so and ctest picks them up then maybe ctest has a bug :/
libc-test/build.rs
Outdated
| "FIONBIO" | ||
| "FIOWRITE" | ||
| "FIONREAD" | ||
| "VXSIM_EWOULDBLOCK" => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't these be fixed?
libc-test/build.rs
Outdated
| "ptsname" | "unlockpt" | "strcasestr" | "socketpair" | ||
| "pwrite64" | "pread64" | "fork" | "_pathIsAbsolute" | "execvp" | ||
| "setgroups" | "signal" | "getpagesize" | "dlclose" | "dlsym" | ||
| "dlerror" | "dlopen" | "setrlimit" | "getrlimit" => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are too many issues. What's wrong with, e.g., mmap
?
153ae40
to
917fe54
Compare
@gnzlbg |
917fe54
to
8edf8e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
// sighandler_t weirdness | ||
"SIG_DFL" | "SIG_ERR" | "SIG_IGN" | ||
// This is not defined in vxWorks | ||
| "RTLD_DEFAULT" => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a FIXME here as well for now.
8edf8e4
to
d1a37cb
Compare
Is it good enough for 'roll'? |
@bors: r+ -- Sorry it took so long, CI has been broken since friday till today. |
📌 Commit d1a37cb has been approved by |
Support vxWorks in libc-test r? @gnzlbg
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
r? @gnzlbg