Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vxWorks in libc-test #1543

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Support vxWorks in libc-test #1543

merged 1 commit into from
Oct 16, 2019

Conversation

BaoshanPang
Copy link
Contributor

r? @gnzlbg

@BaoshanPang
Copy link
Contributor Author

cc @n-salim
cc @maya-cm
cc @UmeshKalappa

"_Vx_EVENTS_RSRC" |
"_Vx_semaphore" |
//Avaliable in Kernel space.
"epoll_event" => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought epoll_event was removed from the libc crate ?

"passwd" |
//the below definitions is part of public/private/
"_Vx_EVENTS_RSRC" |
"_Vx_semaphore" |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these private in the libc crate ? If so and ctest picks them up then maybe ctest has a bug :/

| "FIONBIO"
| "FIOWRITE"
| "FIONREAD"
| "VXSIM_EWOULDBLOCK" => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't these be fixed?

| "ptsname" | "unlockpt" | "strcasestr" | "socketpair"
| "pwrite64" | "pread64" | "fork" | "_pathIsAbsolute" | "execvp"
| "setgroups" | "signal" | "getpagesize" | "dlclose" | "dlsym"
| "dlerror" | "dlopen" | "setrlimit" | "getrlimit" => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are too many issues. What's wrong with, e.g., mmap ?

@BaoshanPang
Copy link
Contributor Author

@gnzlbg
Thanks for pointing out the problems, please help to review the latest code.

@BaoshanPang BaoshanPang force-pushed the master_001 branch 2 times, most recently from 917fe54 to 8edf8e4 Compare October 10, 2019 22:09
Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

// sighandler_t weirdness
"SIG_DFL" | "SIG_ERR" | "SIG_IGN"
// This is not defined in vxWorks
| "RTLD_DEFAULT" => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a FIXME here as well for now.

@BaoshanPang
Copy link
Contributor Author

@gnzlbg

Is it good enough for 'roll'?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 15, 2019

@bors: r+

--

Sorry it took so long, CI has been broken since friday till today.

@bors
Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit d1a37cb has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Oct 15, 2019

⌛ Testing commit d1a37cb with merge f607101...

bors added a commit that referenced this pull request Oct 15, 2019
@bors
Copy link
Contributor

bors commented Oct 16, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing f607101 to master...

@bors bors merged commit d1a37cb into rust-lang:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants