Add a bunch of constants and functions which were missing on Android #1795
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the PR! According to CI, it seems that we should also tweak libc-test to import header files (semver check can be ignored, we should fix that check but I have no bandwidth to do so currently, sorry!). |
|
Thanks. I've added the missing headers, though some of the errors from CI don't seem to be related to that so there may still be some issues. Unfortunately I haven't been able to get the tests to run locally, sorry for the spam. |
|
There is one remaining issue I haven't figured out yet, with sigtimedwait on aarch64 only. I can't see why this arch would be different. The symbol is in signal.h, so shouldn't be arch-specific. It was introduced in API version 23, and android-install-ndk.sh sets version 24 on all Arm architectures or 28 on x86 architectures. Any idea what's going wrong here? |
Possibly related to #1765, I'd skip test for aarch64 at this point as it's obviously safe to ship, I think. Other stuff looks good, r=me once that point is resolved and you squash commits. |
|
Okay, skipping the |
I'd prefer to avoid history-noise than to remain each description except for CI stuff. |
In particular: Add timerfd constants and functions, from sys/timerfd.h. Add EFD_SEMAPHORE and group all EFD_ constants together. Add sigtimedwait function, from signal.h. Add missing fallocate constants and functions, from linux/falloc.h and fcntl.h. Add xattr functions, from sys/xattr.h. Add SCHED_ and SEEK_ constants, from linux/sched.h and bits/seek_constants.h. Add rlimit functions, from sys/resource.h. Add RENAME_ constants, from stdio.h. Add ino64_t type, from sys/types.h.
These are all based on the latest corresponding Bionic headers, from https://cs.android.com/android/platform/superproject/+/master:bionic/.