Add a deprecation note to time_t on musl
#1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnTitor: no appropriate reviewer found, use r? to override |
|
@bors r+ |
|
📌 Commit 61ff741 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 25, 2020
Add a deprecation note to `time_t` on musl cc #1848
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
📌 Commit d40c7eb has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
bors
added a commit
that referenced
this pull request
Oct 12, 2022
add some time functions on glibc and musl #### man pages * [asctime/ctime man page](https://man7.org/linux/man-pages/man3/ctime.3.html) * [strftime](https://man7.org/linux/man-pages/man3/strftime.3.html) * [strptime](https://man7.org/linux/man-pages/man3/strptime.3.html) I didn't add `ctime()/ctime_r()` on musl because they involve the `time_t` type, which elicits [a deprecation wraning](#1956). Is it fine to add these two functions on `musl`, they will have the same definitions as the `glibc` ones: ```rust pub fn ctime(timep: *const time_t) -> *mut ::c_char; pub fn ctime_r(timep: *const time_t, buf: *mut ::c_char) -> *mut ::c_char; ``` If it's ok, I will add them:)
bors
added a commit
that referenced
this pull request
Oct 12, 2022
add some time functions on glibc and musl #### man pages * [asctime/ctime man page](https://man7.org/linux/man-pages/man3/ctime.3.html) * [strftime](https://man7.org/linux/man-pages/man3/strftime.3.html) * [strptime](https://man7.org/linux/man-pages/man3/strptime.3.html) I didn't add `ctime()/ctime_r()` on musl because they involve the `time_t` type, which elicits [a deprecation wraning](#1956). Is it fine to add these two functions on `musl`, they will have the same definitions as the `glibc` ones: ```rust pub fn ctime(timep: *const time_t) -> *mut ::c_char; pub fn ctime_r(timep: *const time_t, buf: *mut ::c_char) -> *mut ::c_char; ``` If it's ok, I will add them:)
bors
added a commit
that referenced
this pull request
Oct 13, 2022
add some time functions on glibc and musl #### man pages * [asctime/ctime man page](https://man7.org/linux/man-pages/man3/ctime.3.html) * [strftime](https://man7.org/linux/man-pages/man3/strftime.3.html) * [strptime](https://man7.org/linux/man-pages/man3/strptime.3.html) I didn't add `ctime()/ctime_r()` on musl because they involve the `time_t` type, which elicits [a deprecation wraning](#1956). Is it fine to add these two functions on `musl`, they will have the same definitions as the `glibc` ones: ```rust pub fn ctime(timep: *const time_t) -> *mut ::c_char; pub fn ctime_r(timep: *const time_t, buf: *mut ::c_char) -> *mut ::c_char; ``` If it's ok, I will add them:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1848