Document stat.st_blksize changes on DragonFly BSD #2487
Conversation
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
What is the long-term solution for this? I don't see how the deprecation warning is helpful since there is no action anyone can do in their code to resolve it. |
|
@Amanieu in a future release, we should update the struct definition to match DragonFly's. This is just an announcement of that future breaking change. My understanding was that this was the correct course of action, per the breaking change policy and previous conversations with @JohnTitor. If we should handle this differently, let me know and I can update the PR. |
|
I will let @JohnTitor review this since you have previously discussed it with him. r? @JohnTitor |
rtzoeller
force-pushed
the
dfly_stat_deprecation
branch
2 times, most recently
from
9a0074e to
1c126a2
Compare
|
Thanks! @bors r+ |
|
📌 Commit 1c126a2 has been approved by |
Document stat.st_blksize changes on DragonFly BSD The tests are currently failing on DragonFly BSD, due to [changes to `stat.st_blksize`](DragonFlyBSD/DragonFlyBSD@34c6728) among other reasons. `st_blksize` is now an `i64`, and has moved to take up a previously reserved struct member. Deprecate the struct, to indicate it will be modified in a subsequent release.
|
💔 Test failed - checks-actions |
|
CI should be fixed now, @bors retry |
Document stat.st_blksize changes on DragonFly BSD The tests are currently failing on DragonFly BSD, due to [changes to `stat.st_blksize`](DragonFlyBSD/DragonFlyBSD@34c6728) among other reasons. `st_blksize` is now an `i64`, and has moved to take up a previously reserved struct member. Deprecate the struct, to indicate it will be modified in a subsequent release.
|
💔 Test failed - checks-actions |
|
Some functions need |
rtzoeller
force-pushed
the
dfly_stat_deprecation
branch
from
1c126a2 to
9d11d8d
Compare
|
@JohnTitor fixed! For some reason I couldn't see the actual error in the log on GitHub, and had to download it and view it locally. |
Hm, it's displayed fine on my env, maybe loading the log failed at that time? Anyway, the build should be fixed, @bors r+ |
|
📌 Commit 9d11d8d has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
The tests are currently failing on DragonFly BSD, due to changes to
stat.st_blksizeamong other reasons.st_blksizeis now ani64, and has moved to take up a previously reserved struct member. Deprecate the struct, to indicate it will be modified in a subsequent release.