Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support atomic_fence instrinstic #972

Closed
jonhoo opened this issue Sep 30, 2019 · 6 comments · Fixed by #979
Closed

Support atomic_fence instrinstic #972

jonhoo opened this issue Sep 30, 2019 · 6 comments · Fixed by #979
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement E-good-first-issue A good way to start contributing, mentoring is available

Comments

@jonhoo
Copy link

jonhoo commented Sep 30, 2019

I'd love to try miri on evmap, but sadly I get the following error:

error[E0080]: Miri evaluation error: unimplemented intrinsic: atomic_fence
    --> /home/jon/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libcore/sync/atomic.rs:2412:23
     |
2412 |             SeqCst => intrinsics::atomic_fence(),
     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ Miri evaluation error: unimplemented intrinsic: atomic_fence
     |
note: inside call to `std::sync::atomic::fence` at src/write.rs:306:9
    --> src/write.rs:306:9
     |
306  |         atomic::fence(atomic::Ordering::SeqCst);
     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is this a known issue? Some cursory searching did not yield anything that seemed relevant.

@RalfJung RalfJung added A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement labels Oct 1, 2019
@RalfJung
Copy link
Member

RalfJung commented Oct 1, 2019

This is just a missing shim. The shim should not do anything so this should be easy to fix.

@RalfJung RalfJung added the E-good-first-issue A good way to start contributing, mentoring is available label Oct 1, 2019
bors added a commit that referenced this issue Oct 5, 2019
Add missing atomic_fence intrinsics as nops

Fixes #972
@bors bors closed this as completed in 0c40036 Oct 5, 2019
@bors bors closed this as completed in #979 Oct 5, 2019
@jonhoo
Copy link
Author

jonhoo commented Oct 10, 2019

I'm guess we also need to do something special to get the miri installed by rustup to pick this up?

@RalfJung
Copy link
Member

Yeah, the miri submodule in rustc (at src/tools/miri) needs to be updated. Do you want to make a PR?

@jonhoo
Copy link
Author

jonhoo commented Oct 10, 2019

Sure, I'll do that, thanks!

@RalfJung
Copy link
Member

RalfJung commented Oct 10, 2019

Remember to run ./x.py (with no arguments) after updating the submodule (and comitting!) to make sure your Cargo.lock is up-to-date.

@jonhoo
Copy link
Author

jonhoo commented Oct 10, 2019

rust-lang/rust#65278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement E-good-first-issue A good way to start contributing, mentoring is available
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants